feat(video3d): cafe-dance set with textured building, floor and street - #209
Merged
Conversation
… street A rectangular cafe box, terrazzo floor and dusk street plane, each with its own texture. The character stands in front facing the camera. Clip names stay unbound. Follows merged #204; does not touch the 2.5D compositor.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_51e69005-711a-4780-b177-ec0b21e7b763) |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 53.9/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A music-video template that is a small 3D set, not a scrolling cylinder: one rectangular cafe, a floor, and a street backdrop, each with its own texture, and the character dancing in front.
What
cafe-dance, camera familyfront(chest height, looking at the subject)cafe: box building (facade map), terrazzo plane, dusk street planeui/public/scene3d/index+ exact glTF name)Does not touch
SceneAnimatorPanelor the 2.5D compositor.Checks
tsx --test tests/scene3dStage.test.mjs14/14node scripts/check-i18n-catalogs.mjsokscene3dfiles cleanLocal proof (not in git): http://192.168.1.87:36592/videos/clip-cafe-dance.mp4
Do not merge until asked.
Note
Low Risk
Scoped to the Video 3D stage (templates, dressing, camera, async textures); no auth or backend changes, with export gated on texture readiness.
Overview
Adds a
cafe-dancemusic-video template: a fixed cafe set (textured building, floor, street backdrop) instead of a scrolling cylinder background, with a single subject slot and clips left unbound.Introduces dressing
cafevia newcafeSet.ts(loads facade/floor/back textures, builds the 3D group with fallbacks).Scene3DStageloads cafe maps asynchronously, re-syncs dressing when textures arrive, and tracksdressingReadyso MP4 export waits until cafe assets finish loading. The default circular floor is hidden for cafe dressing.Adds camera family
front(chest-height, subject look-at, fixed eye incamera.ts) and wires it through templates, document parsing, workspace family picker, and en/es i18n. Includes a regression test for thecafe-dancetemplate shape and camera geometry.Reviewed by Cursor Bugbot for commit e6aa2bf. Configure here.